V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

x86: Remove unnecessary casts and fix comment typos 

Tidy up the FSP support code a little.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
This commit is contained in:
Simon Glass 2015-01-27 22:13:40 -07:00
parent 91785f70b9
commit f0809f9a38
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
arch/x86/lib/fsp/fsp_support.c
View File

@ -124,25 +124,25 @@ void fsp_init(u32 stack_top, u32 boot_mode, void *nvs_buf)
struct fsp_init_params *params_ptr; struct fsp_init_params *params_ptr;
struct upd_region *fsp_upd; struct upd_region *fsp_upd;
fsp_hdr = (struct fsp_header *)find_fsp_header(); fsp_hdr = find_fsp_header();
if (fsp_hdr == NULL) { if (fsp_hdr == NULL) {
/* No valid FSP info header was found */ /* No valid FSP info header was found */
panic("Invalid FSP header"); panic("Invalid FSP header");
} }
fsp_upd = (struct upd_region *)&shared_data.fsp_upd; fsp_upd = &shared_data.fsp_upd;
memset(&rt_buf, 0, sizeof(struct fspinit_rtbuf)); memset(&rt_buf, 0, sizeof(struct fspinit_rtbuf));
/* Reserve a gap in stack top */ /* Reserve a gap in stack top */
rt_buf.common.stack_top = (u32 *)stack_top - 32; rt_buf.common.stack_top = (u32 *)stack_top - 32;
rt_buf.common.boot_mode = boot_mode; rt_buf.common.boot_mode = boot_mode;
rt_buf.common.upd_data = (struct upd_region *)fsp_upd; rt_buf.common.upd_data = fsp_upd;
/* Get VPD region start */ /* Get VPD region start */
fsp_vpd = (struct vpd_region *)(fsp_hdr->img_base + fsp_vpd = (struct vpd_region *)(fsp_hdr->img_base +
fsp_hdr->cfg_region_off); fsp_hdr->cfg_region_off);
/* Verifify the VPD data region is valid */ /* Verify the VPD data region is valid */
assert((fsp_vpd->img_rev == VPD_IMAGE_REV) && assert((fsp_vpd->img_rev == VPD_IMAGE_REV) &&
(fsp_vpd->sign == VPD_IMAGE_ID)); (fsp_vpd->sign == VPD_IMAGE_ID));
@ -150,7 +150,7 @@ void fsp_init(u32 stack_top, u32 boot_mode, void *nvs_buf)
memcpy(fsp_upd, (void *)(fsp_hdr->img_base + fsp_vpd->upd_offset), memcpy(fsp_upd, (void *)(fsp_hdr->img_base + fsp_vpd->upd_offset),
sizeof(struct upd_region)); sizeof(struct upd_region));
/* Verifify the UPD data region is valid */ /* Verify the UPD data region is valid */
assert(fsp_upd->terminator == UPD_TERMINATOR); assert(fsp_upd->terminator == UPD_TERMINATOR);
/* Override any UPD setting if required */ /* Override any UPD setting if required */