V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

cmd_mtdparts.c: prevent printbuffer overflows 

The length of configured MTDPARTS_DEFAULT string
could be greater than console printbuffer size.
Replace printf() by puts() to avoid potential buffer
overflows.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
This commit is contained in:
Anatolij Gustschin 2010-02-24 00:29:44 +01:00 committed by Wolfgang Denk
parent 3920bbedcf
commit a693447cea
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
common/cmd_mtdparts.c
View File

@ -1254,8 +1254,14 @@ static void list_partitions(void)
printf("\ndefaults:\n"); printf("\ndefaults:\n");
printf("mtdids : %s\n", printf("mtdids : %s\n",
mtdids_default ? mtdids_default : "none"); mtdids_default ? mtdids_default : "none");
printf("mtdparts: %s\n", /*
mtdparts_default ? mtdparts_default : "none"); * Using printf() here results in printbuffer overflow
* if default mtdparts string is greater than console
* printbuffer. Use puts() to prevent system crashes.
*/
puts("mtdparts: ");
puts(mtdparts_default ? mtdparts_default : "none");
puts("\n");
} }
/** /**