V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

dm: rtc: Correct rtc_read32() return value 

The current check is incorrect and will fail when any non-zero byte is read.
Fix it.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
This commit is contained in:
Simon Glass 2015-10-18 15:55:31 -06:00
parent b26eb88658
commit 9a4eb5977a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/rtc/rtc-uclass.c
View File

@ -68,7 +68,7 @@ int rtc_read32(struct udevice *dev, unsigned int reg, u32 *valuep)
for (i = 0; i < sizeof(value); i++) { for (i = 0; i < sizeof(value); i++) {
ret = rtc_read8(dev, reg + i); ret = rtc_read8(dev, reg + i);
if (ret) if (ret < 0)
return ret; return ret;
value |= ret << (i << 3); value |= ret << (i << 3);
} }