V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

main: Avoid unncessary strdup()/free() 

It doesn't seem necessary to use memory allocation in this code. The setenv()
will make a copy anyway.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2014-04-10 20:01:36 -06:00 committed by Tom Rini
parent affb215626
commit 95856248ca
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common/main.c
View File

@ -10,7 +10,6 @@
#include <common.h> #include <common.h>
#include <autoboot.h> #include <autoboot.h>
#include <cli.h> #include <cli.h>
#include <malloc.h>
#include <version.h> #include <version.h>
DECLARE_GLOBAL_DATA_PTR; DECLARE_GLOBAL_DATA_PTR;
@ -26,10 +25,9 @@ static void modem_init(void)
#ifdef CONFIG_MODEM_SUPPORT #ifdef CONFIG_MODEM_SUPPORT
debug("DEBUG: main_loop: gd->do_mdm_init=%lu\n", gd->do_mdm_init); debug("DEBUG: main_loop: gd->do_mdm_init=%lu\n", gd->do_mdm_init);
if (gd->do_mdm_init) { if (gd->do_mdm_init) {
char *str = strdup(getenv("mdm_cmd")); char *str = getenv("mdm_cmd");
setenv("preboot", str); /* set or delete definition */ setenv("preboot", str); /* set or delete definition */
if (str != NULL)
free(str);
mdm_init(); /* wait for modem connection */ mdm_init(); /* wait for modem connection */
} }
#endif /* CONFIG_MODEM_SUPPORT */ #endif /* CONFIG_MODEM_SUPPORT */