V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

itest: add missing break statements to evalexp() 

The commit mentioned below replaced return statements inside a switch so
that other code could be called after the switch. However, it didn't add
any break statements, causing the cases to run together. Fix this.

Reported-by: Coverity (CID 132282, 132283)
Fixes: 7861204c9a ("itest: make memory access work under sandbox")
Signed-off-by: Stephen Warren <swarren@nvidia.com>
This commit is contained in:
Stephen Warren 2015-11-17 10:29:08 -07:00 committed by Tom Rini
parent 34a60d9bc8
commit 736d1746fb
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
common/cmd_itest.c
View File

@ -64,9 +64,15 @@ static long evalexp(char *s, int w)
return 0;
}
switch (w) {
case 1: l = (long)(*(unsigned char *)buf);
case 2: l = (long)(*(unsigned short *)buf);
case 4: l = (long)(*(unsigned long *)buf);
case 1:
l = (long)(*(unsigned char *)buf);
break;
case 2:
l = (long)(*(unsigned short *)buf);
break;
case 4:
l = (long)(*(unsigned long *)buf);
break;
}
unmap_physmem(buf, w);
return l;