V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

net: cosmetic: Clean up RARP variables and functions 

Make a thorough pass through all variables and function names contained
within rarp.c and remove CamelCase and improve naming.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Joe Hershberger 2015-04-08 01:41:11 -05:00 committed by Simon Glass
parent 68c76a3a38
commit 698d78e545
3 changed files with 16 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/net.c
View File

@ -395,9 +395,9 @@ restart:
#if defined(CONFIG_CMD_RARP) #if defined(CONFIG_CMD_RARP)
case RARP: case RARP:
RarpTry = 0; rarp_try = 0;
net_ip.s_addr = 0; net_ip.s_addr = 0;
RarpRequest(); rarp_request();
break; break;
#endif #endif
#if defined(CONFIG_CMD_PING) #if defined(CONFIG_CMD_PING)

23
net/rarp.c
View File

@ -20,7 +20,7 @@
#define TIMEOUT_COUNT (CONFIG_NET_RETRY_COUNT) #define TIMEOUT_COUNT (CONFIG_NET_RETRY_COUNT)
#endif #endif
int RarpTry; int rarp_try;
/* /*
* Handle a RARP received packet. * Handle a RARP received packet.
@ -37,10 +37,9 @@ void rarp_receive(struct ip_udp_hdr *ip, unsigned len)
} }
if ((ntohs(arp->ar_op) != RARPOP_REPLY) || if ((ntohs(arp->ar_op) != RARPOP_REPLY) ||
(ntohs(arp->ar_hrd) != ARP_ETHER) || (ntohs(arp->ar_hrd) != ARP_ETHER) ||
(ntohs(arp->ar_pro) != PROT_IP) || (ntohs(arp->ar_pro) != PROT_IP) ||
(arp->ar_hln != 6) || (arp->ar_pln != 4)) { (arp->ar_hln != 6) || (arp->ar_pln != 4)) {
puts("invalid RARP header\n"); puts("invalid RARP header\n");
} else { } else {
net_copy_ip(&net_ip, &arp->ar_data[16]); net_copy_ip(&net_ip, &arp->ar_data[16]);
@ -56,25 +55,25 @@ void rarp_receive(struct ip_udp_hdr *ip, unsigned len)
/* /*
* Timeout on BOOTP request. * Timeout on BOOTP request.
*/ */
static void RarpTimeout(void) static void rarp_timeout_handler(void)
{ {
if (RarpTry >= TIMEOUT_COUNT) { if (rarp_try >= TIMEOUT_COUNT) {
puts("\nRetry count exceeded; starting again\n"); puts("\nRetry count exceeded; starting again\n");
NetStartAgain(); NetStartAgain();
} else { } else {
NetSetTimeout(TIMEOUT, RarpTimeout); NetSetTimeout(TIMEOUT, rarp_timeout_handler);
RarpRequest(); rarp_request();
} }
} }
void RarpRequest(void) void rarp_request(void)
{ {
uchar *pkt; uchar *pkt;
struct arp_hdr *rarp; struct arp_hdr *rarp;
int eth_hdr_size; int eth_hdr_size;
printf("RARP broadcast %d\n", ++RarpTry); printf("RARP broadcast %d\n", ++rarp_try);
pkt = net_tx_packet; pkt = net_tx_packet;
eth_hdr_size = net_set_ether(pkt, net_bcast_ethaddr, PROT_RARP); eth_hdr_size = net_set_ether(pkt, net_bcast_ethaddr, PROT_RARP);
@ -96,5 +95,5 @@ void RarpRequest(void)
net_send_packet(net_tx_packet, eth_hdr_size + ARP_HDR_SIZE); net_send_packet(net_tx_packet, eth_hdr_size + ARP_HDR_SIZE);
NetSetTimeout(TIMEOUT, RarpTimeout); NetSetTimeout(TIMEOUT, rarp_timeout_handler);
} }

6
net/rarp.h
View File

@ -17,11 +17,11 @@
* Global functions and variables. * Global functions and variables.
*/ */
extern int RarpTry; extern int rarp_try;
/* Process the receipt of a RARP packet */ /* Process the receipt of a RARP packet */
extern void rarp_receive(struct ip_udp_hdr *ip, unsigned len); void rarp_receive(struct ip_udp_hdr *ip, unsigned len);
extern void RarpRequest(void); /* Send a RARP request */ void rarp_request(void); /* Send a RARP request */
/**********************************************************************/ /**********************************************************************/