V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

wandboard: Simplify the Ethernet PHY configuration 

As per the AR8031 datasheet:

"For a reliable power on reset, suggest to keep asserting the reset
low long enough (10ms) to ensure the clock is stable and clock-to-reset
1ms requirement is satisfied."

So do as suggested and also add a 100us delay after deasserting the
reset line to guarantee that the PHY ID can be read correctly and the
Atheros 8031 PHY driver can be loaded automatically.

This results in a simpler code.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
This commit is contained in:
Fabio Estevam 2016-01-05 17:02:54 -02:00 committed by Stefano Babic
parent a307760ab4
commit 59a6ca54f5
1 changed files with 2 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
board/wandboard/wandboard.c
View File

@ -121,8 +121,9 @@ static void setup_iomux_enet(void)
/* Reset AR8031 PHY */ /* Reset AR8031 PHY */
gpio_direction_output(ETH_PHY_RESET, 0); gpio_direction_output(ETH_PHY_RESET, 0);
udelay(500); mdelay(10);
gpio_set_value(ETH_PHY_RESET, 1); gpio_set_value(ETH_PHY_RESET, 1);
udelay(100);
} }
static struct fsl_esdhc_cfg usdhc_cfg[2] = { static struct fsl_esdhc_cfg usdhc_cfg[2] = {
@ -187,39 +188,6 @@ int board_mmc_init(bd_t *bis)
return 0; return 0;
} }
static int mx6_rgmii_rework(struct phy_device *phydev)
{
unsigned short val;
/* To enable AR8031 ouput a 125MHz clk from CLK_25M */
phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x7);
phy_write(phydev, MDIO_DEVAD_NONE, 0xe, 0x8016);
phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x4007);
val = phy_read(phydev, MDIO_DEVAD_NONE, 0xe);
val &= 0xffe3;
val |= 0x18;
phy_write(phydev, MDIO_DEVAD_NONE, 0xe, val);
/* introduce tx clock delay */
phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x5);
val = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e);
val |= 0x0100;
phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, val);
return 0;
}
int board_phy_config(struct phy_device *phydev)
{
mx6_rgmii_rework(phydev);
if (phydev->drv->config)
phydev->drv->config(phydev);
return 0;
}
#if defined(CONFIG_VIDEO_IPUV3) #if defined(CONFIG_VIDEO_IPUV3)
struct i2c_pads_info mx6q_i2c2_pad_info = { struct i2c_pads_info mx6q_i2c2_pad_info = {
.scl = { .scl = {