V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

mkimage: Correct file being closed twice in fit_import_data() 

The code flows through to the end of the function, so we don't need another
close() before this. Remove it.

Reported-by: Coverity (CID: 138504)

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
This commit is contained in:
Simon Glass 2016-03-16 07:45:32 -06:00 committed by Tom Rini
parent 9cff2d1e39
commit 508b028a4c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/fit_image.c
View File

@ -530,6 +530,7 @@ static int fit_import_data(struct image_tool_params *params, const char *fname)
if (fd < 0) { if (fd < 0) {
fprintf(stderr, "%s: Can't open %s: %s\n", fprintf(stderr, "%s: Can't open %s: %s\n",
params->cmdname, fname, strerror(errno)); params->cmdname, fname, strerror(errno));
ret = -EIO;
goto err; goto err;
} }
if (write(fd, fdt, new_size) != new_size) { if (write(fd, fdt, new_size) != new_size) {
@ -538,7 +539,6 @@ static int fit_import_data(struct image_tool_params *params, const char *fname)
ret = -EIO; ret = -EIO;
goto err; goto err;
} }
close(fd);
ret = 0; ret = 0;