V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Fix comment nits in board_f.c 

Try to make it a little clearer.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
This commit is contained in:
Simon Glass 2015-04-28 20:25:03 -06:00
parent 410b10f1e3
commit 4c509343ab
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
common/board_f.c
View File

@ -73,7 +73,7 @@ DECLARE_GLOBAL_DATA_PTR;
#endif #endif
/* /*
* sjg: IMO this code should be * TODO(sjg@chromium.org): IMO this code should be
* refactored to a single function, something like: * refactored to a single function, something like:
* *
* void led_set_state(enum led_colour_t colour, int on); * void led_set_state(enum led_colour_t colour, int on);
@ -300,7 +300,7 @@ __weak ulong board_get_usable_ram_top(ulong total_size)
{ {
#ifdef CONFIG_SYS_SDRAM_BASE #ifdef CONFIG_SYS_SDRAM_BASE
/* /*
* Detect whether we have so much RAM it goes past the end of our * Detect whether we have so much RAM that it goes past the end of our
* 32-bit address space. If so, clip the usable RAM so it doesn't. * 32-bit address space. If so, clip the usable RAM so it doesn't.
*/ */
if (gd->ram_top < CONFIG_SYS_SDRAM_BASE) if (gd->ram_top < CONFIG_SYS_SDRAM_BASE)
@ -507,7 +507,7 @@ static int reserve_global_data(void)
static int reserve_fdt(void) static int reserve_fdt(void)
{ {
/* /*
* If the device tree is sitting immediate above our image then we * If the device tree is sitting immediately above our image then we
* must relocate it. If it is embedded in the data section, then it * must relocate it. If it is embedded in the data section, then it
* will be relocated with other data. * will be relocated with other data.
*/ */
@ -535,7 +535,7 @@ static int reserve_stacks(void)
gd->start_addr_sp &= ~0xf; gd->start_addr_sp &= ~0xf;
/* /*
* let the architecture specific code tailor gd->start_addr_sp and * let the architecture-specific code tailor gd->start_addr_sp and
* gd->irq_sp * gd->irq_sp
*/ */
return arch_reserve_stacks(); return arch_reserve_stacks();
@ -556,7 +556,6 @@ static int setup_board_part1(void)
/* /*
* Save local variables to board info struct * Save local variables to board info struct
*/ */
bd->bi_memstart = CONFIG_SYS_SDRAM_BASE; /* start of memory */ bd->bi_memstart = CONFIG_SYS_SDRAM_BASE; /* start of memory */
bd->bi_memsize = gd->ram_size; /* size in bytes */ bd->bi_memsize = gd->ram_size; /* size in bytes */