V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

common/command.c: revert changes from commit 199adb60 

commit 199adb601f "common/misc: sparse
fixes" broke the help command trying to fix the sparse error
"command.c:44:38: error: bad constant expression".

As Henrik points out, the fix was bad because the commit used
CONFIG_SYS_MAXARGS whereas the code intended to use the maximum
number of commands (not arguments to a command).

Revert command.c changes to the original code as asked by Wolfgang.

Reported-by: Henrik Nordström <henrik@henriknordstrom.net>
Signed-off-by: Anatolij Gustschin <agust@denx.de>
This commit is contained in:
Anatolij Gustschin 2012-11-08 12:40:17 +01:00
parent 1cc619be8b
commit 22b6fcb50d
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
common/command.c
View File

@ -40,15 +40,8 @@ int _do_help (cmd_tbl_t *cmd_start, int cmd_items, cmd_tbl_t * cmdtp, int
int i; int i;
int rcode = 0; int rcode = 0;
if (cmd_items > CONFIG_SYS_MAXARGS) {
printf("%s: cmd_items %d exceeds hardcoded limit %d."
" Recompile with higher CONFIG_SYS_MAXARGS?\n",
__func__, cmd_items, CONFIG_SYS_MAXARGS);
return -1;
}
if (argc == 1) { /*show list of commands */ if (argc == 1) { /*show list of commands */
cmd_tbl_t *cmd_array[CONFIG_SYS_MAXARGS]; cmd_tbl_t *cmd_array[cmd_items];
int i, j, swaps; int i, j, swaps;
/* Make array of commands from .uboot_cmd section */ /* Make array of commands from .uboot_cmd section */