V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

tools/proftool: fix use-after-free 

The read_trace_config() can dereference the line pointer after freeing
it on its error path. Avoid that.

This was found by Coverity Scan.

Signed-off-by: Vincent Stehlé <vincent.stehle@freescale.com>
Cc: Simon Glass <sjg@chromium.org>
This commit is contained in:
Vincent Stehlé 2015-10-07 15:48:48 +02:00 committed by Tom Rini
parent 98e73c8344
commit 1ca8f8818b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/proftool.c
View File

@ -432,9 +432,10 @@ static int read_trace_config(FILE *fin)
err = regcomp(&line->regex, tok, REG_NOSUB); err = regcomp(&line->regex, tok, REG_NOSUB);
if (err) { if (err) {
int r = regex_report_error(&line->regex, err,
"compile", tok);
free(line); free(line);
return regex_report_error(&line->regex, err, "compile", return r;
tok);
} }
/* link this new one to the end of the list */ /* link this new one to the end of the list */