V3s_Allwinner
/
uboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

sandboxfs: Fix resource leak 

Now that we free resources in sandbox_fs_ls Coverity is letting us know
that in some cases we might leak.  So in case of error we should still
let os_dirent_free free anything that was allocated.

Fixes: 86167089b7 ("sandbox/fs: Free memory allocated by os_dirent_ls")
Reported-by: Coverity (CID: 153450)
Cc: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Tom Rini 2016-10-17 21:09:32 -04:00 committed by Simon Glass
parent a982b6f514
commit 0317724e6c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/sandbox/sandboxfs.c
View File

@ -88,15 +88,16 @@ int sandbox_fs_ls(const char *dirname)
ret = os_dirent_ls(dirname, &head); ret = os_dirent_ls(dirname, &head);
if (ret) if (ret)
return ret; goto out;
for (node = head; node; node = node->next) { for (node = head; node; node = node->next) {
printf("%s %10lu %s\n", os_dirent_get_typename(node->type), printf("%s %10lu %s\n", os_dirent_get_typename(node->type),
node->size, node->name); node->size, node->name);
} }
out:
os_dirent_free(head); os_dirent_free(head);
return 0; return ret;
} }
int sandbox_fs_exists(const char *filename) int sandbox_fs_exists(const char *filename)